Added length type wrapper in sockaddr_any for convenience. #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
Priority: Low
Type: Enhancement
| int64_t srctime = 0; | ||
| int stat = recvfrom(m_sock, data.data(), (int) chunk, 0, sa.get(), &si); | ||
| int stat = recvfrom(m_sock, data.data(), (int) chunk, 0, sa.get(), &sa.syslen()); |
There was a problem hiding this comment.
Dereferencing a temporal object SysLenWrapper::syslen.... 🤔
There was a problem hiding this comment.
Allowed, as long as you don't access it after it is deleted. We know it is not deleted until the current instruction finishes execution, so it won't happen before returning from the function. It actually does the same as the "temporary variable" solution used previously, just the trick is hidden inside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a possibility to easily specify the forwarder for the
lenfield insockaddr_anyusable with system functions.The SRT API is using
inttype for length of the address specified bysockaddr*, whereas system functions usesocklen_ton Linux (which resolves to various combinations) orinton Windows. To satisfy normal needs, thelenfield is ofinttype, but this way it can't be passed to system functions by pointer.This makes it possible to pass a pointer to a system length type, as the system function require, and transparently bind it to the
lenfield.