Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Replaced CTimer with new CTimer #1174

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Mar 9, 2020

This PR consists of two commits.
The first commit replaces the old CTimer with the new one based on sync objects.
But CTimer used to work with a monotonic clock, whereas after the change it uses the regular clock.
The latter is solved by the second commit, which makes all CVs and timers monotonic if the monotonic clock is enabled.

@maxsharabayko maxsharabayko force-pushed the develop/sync_05_timer branch from a3f4d84 to 9e0994b Compare March 9, 2020 15:41
@maxsharabayko maxsharabayko mentioned this pull request Mar 9, 2020
18 tasks
@maxsharabayko maxsharabayko marked this pull request as ready for review March 17, 2020 10:01
@maxsharabayko maxsharabayko requested a review from ethouris March 17, 2020 10:03
srtcore/queue.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@ethouris ethouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider.

srtcore/sync.cpp Outdated Show resolved Hide resolved
@maxsharabayko maxsharabayko force-pushed the develop/sync_05_timer branch from 1ee8cd0 to 11abc1d Compare March 18, 2020 05:52
@maxsharabayko maxsharabayko requested a review from ethouris March 18, 2020 05:53
@maxsharabayko maxsharabayko added this to the v1.5.0 milestone Mar 18, 2020
@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code labels Mar 18, 2020
@maxsharabayko maxsharabayko merged commit 6598a13 into Haivision:master Mar 18, 2020
@maxsharabayko maxsharabayko deleted the develop/sync_05_timer branch March 18, 2020 10:42
@maxsharabayko maxsharabayko mentioned this pull request Mar 18, 2020
13 tasks
@mbakholdina mbakholdina modified the milestones: v1.5.0, v1.4.2 Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants