Added cosmetix from the pre-group-refax #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
Priority: High
Type: Maintenance
srtcore/api.cpp
Outdated
Comment on lines
330
to
332
| // connection already exist, this is a repeated connection request | ||
| // respond with existing HS information | ||
| // respond with existing HS information | ||
| HLOGC(mglog.Debug, log |
Alright. So hold horses until I make this one. |
|
#1077 is handling the renames. |
|
#1077 is merged - updated this PR |
maxsharabayko
requested changes
Jan 22, 2020
srtcore/epoll.cpp
Outdated
Comment on lines
73
to
74
| // Use "inline namespace" in C++11 | ||
| namespace srt_logging |
There was a problem hiding this comment.
No point in this comment. For very distant future?
There was a problem hiding this comment.
Likely. Old times. I'll remove it, it's useless anyway.
srtcore/packet.h
Outdated
Comment on lines
421
to
422
| std::string MessageFlagStr() { return ""; } | ||
| std::string Info() { return ""; } |
There was a problem hiding this comment.
return std::string() to avoid implicit conversions?
added 2 commits
January 22, 2020 11:09
|
The build needs to be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommended turning off whitespace difs for review.