Skip to content

Commit

Permalink
[core] fix unrecoverable initial packets lose in group message mode
Browse files Browse the repository at this point in the history
  • Loading branch information
gou4shi1 authored and maxsharabayko committed Mar 14, 2022
1 parent fe5debb commit 3975428
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions srtcore/core.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9894,8 +9894,6 @@ int srt::CUDT::processData(CUnit* in_unit)
}
}

bool need_notify_loss = true;

// [[using locked()]]; // (NOTHING locked)

#if ENABLE_EXPERIMENTAL_BONDING
Expand Down Expand Up @@ -9923,10 +9921,6 @@ int srt::CUDT::processData(CUnit* in_unit)
<< srt_log_grp_state[gi->rcvstate]
<< " -> RUNNING. NOT checking for loss");
gi->rcvstate = SRT_GST_RUNNING;

// The function unfortunately can't return here.
// We just need to skip loss reporting.
need_notify_loss = false;
}
else
{
Expand Down Expand Up @@ -10119,7 +10113,7 @@ int srt::CUDT::processData(CUnit* in_unit)
HLOGC(qrlog.Debug,
log << "CONTIGUITY CHECK: sequence distance: " << CSeqNo::seqoff(m_iRcvCurrSeqNo, rpkt.m_iSeqNo));

if (need_notify_loss && CSeqNo::seqcmp(rpkt.m_iSeqNo, CSeqNo::incseq(m_iRcvCurrSeqNo)) > 0) // Loss detection.
if (CSeqNo::seqcmp(rpkt.m_iSeqNo, CSeqNo::incseq(m_iRcvCurrSeqNo)) > 0) // Loss detection.
{
int32_t seqlo = CSeqNo::incseq(m_iRcvCurrSeqNo);
int32_t seqhi = CSeqNo::decseq(rpkt.m_iSeqNo);
Expand Down

0 comments on commit 3975428

Please sign in to comment.