-
Notifications
You must be signed in to change notification settings - Fork 866
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[core] Added atomic support and marked atomic key fields detected by …
…thread sanitizer (#1863)
- Loading branch information
Showing
11 changed files
with
677 additions
and
112 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,210 @@ | ||
| //---------------------------------------------------------------------------- | ||
| // This is free and unencumbered software released into the public domain. | ||
| // | ||
| // Anyone is free to copy, modify, publish, use, compile, sell, or distribute | ||
| // this software, either in source code form or as a compiled binary, for any | ||
| // purpose, commercial or non-commercial, and by any means. | ||
| // | ||
| // In jurisdictions that recognize copyright laws, the author or authors of | ||
| // this software dedicate any and all copyright interest in the software to the | ||
| // public domain. We make this dedication for the benefit of the public at | ||
| // large and to the detriment of our heirs and successors. We intend this | ||
| // dedication to be an overt act of relinquishment in perpetuity of all present | ||
| // and future rights to this software under copyright law. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN | ||
| // ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION | ||
| // WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| // | ||
| // For more information, please refer to <http://unlicense.org/> | ||
| //----------------------------------------------------------------------------- | ||
|
|
||
| // SRT Project information: | ||
| // This file was adopted from a Public Domain project from | ||
| // https://github.com/mbitsnbites/atomic | ||
| // Only namespaces were changed to adopt it for SRT project. | ||
|
|
||
| #ifndef SRT_SYNC_ATOMIC_H_ | ||
| #define SRT_SYNC_ATOMIC_H_ | ||
|
|
||
| // Macro for disallowing copying of an object. | ||
| #if __cplusplus >= 201103L | ||
| #define ATOMIC_DISALLOW_COPY(T) \ | ||
| T(const T&) = delete; \ | ||
| T& operator=(const T&) = delete; | ||
| #else | ||
| #define ATOMIC_DISALLOW_COPY(T) \ | ||
| T(const T&); \ | ||
| T& operator=(const T&); | ||
| #endif | ||
|
|
||
| // A portable static assert. | ||
| #if __cplusplus >= 201103L | ||
| #define ATOMIC_STATIC_ASSERT(condition, message) \ | ||
| static_assert((condition), message) | ||
| #else | ||
| // Based on: http://stackoverflow.com/a/809465/5778708 | ||
| #define ATOMIC_STATIC_ASSERT(condition, message) \ | ||
| _impl_STATIC_ASSERT_LINE(condition, __LINE__) | ||
| #define _impl_PASTE(a, b) a##b | ||
| #ifdef __GNUC__ | ||
| #define _impl_UNUSED __attribute__((__unused__)) | ||
| #else | ||
| #define _impl_UNUSED | ||
| #endif | ||
| #define _impl_STATIC_ASSERT_LINE(condition, line) \ | ||
| typedef char _impl_PASTE( \ | ||
| STATIC_ASSERT_failed_, \ | ||
| line)[(2 * static_cast<int>(!!(condition))) - 1] _impl_UNUSED | ||
| #endif | ||
|
|
||
| #if defined(__GNUC__) || defined(__clang__) || defined(__xlc__) | ||
| #define ATOMIC_USE_GCC_INTRINSICS | ||
| #elif defined(_MSC_VER) | ||
| #define ATOMIC_USE_MSVC_INTRINSICS | ||
| #include "atomic_msvc.h" | ||
| #elif __cplusplus >= 201103L | ||
| #define ATOMIC_USE_CPP11_ATOMIC | ||
| #include <atomic> | ||
| #else | ||
| #error Unsupported compiler / system. | ||
| #endif | ||
|
|
||
| namespace srt { | ||
| namespace sync { | ||
| template <typename T> | ||
| class atomic { | ||
| public: | ||
| ATOMIC_STATIC_ASSERT(sizeof(T) == 1 || sizeof(T) == 2 || sizeof(T) == 4 || | ||
| sizeof(T) == 8, | ||
| "Only types of size 1, 2, 4 or 8 are supported"); | ||
|
|
||
| atomic() : value_(static_cast<T>(0)) {} | ||
|
|
||
| explicit atomic(const T value) : value_(value) {} | ||
|
|
||
| /// @brief Performs an atomic increment operation (value + 1). | ||
| /// @returns The new value of the atomic object. | ||
| T operator++() { | ||
| #if defined(ATOMIC_USE_GCC_INTRINSICS) | ||
| return __atomic_add_fetch(&value_, 1, __ATOMIC_SEQ_CST); | ||
| #elif defined(ATOMIC_USE_MSVC_INTRINSICS) | ||
| return msvc::interlocked<T>::increment(&value_); | ||
| #else | ||
| return ++value_; | ||
| #endif | ||
| } | ||
|
|
||
| /// @brief Performs an atomic decrement operation (value - 1). | ||
| /// @returns The new value of the atomic object. | ||
| T operator--() { | ||
| #if defined(ATOMIC_USE_GCC_INTRINSICS) | ||
| return __atomic_sub_fetch(&value_, 1, __ATOMIC_SEQ_CST); | ||
| #elif defined(ATOMIC_USE_MSVC_INTRINSICS) | ||
| return msvc::interlocked<T>::decrement(&value_); | ||
| #else | ||
| return --value_; | ||
| #endif | ||
| } | ||
|
|
||
| /// @brief Performs an atomic compare-and-swap (CAS) operation. | ||
| /// | ||
| /// The value of the atomic object is only updated to the new value if the | ||
| /// old value of the atomic object matches @c expected_val. | ||
| /// | ||
| /// @param expected_val The expected value of the atomic object. | ||
| /// @param new_val The new value to write to the atomic object. | ||
| /// @returns True if new_value was written to the atomic object. | ||
| bool compare_exchange(const T expected_val, const T new_val) { | ||
| #if defined(ATOMIC_USE_GCC_INTRINSICS) | ||
| T e = expected_val; | ||
| return __atomic_compare_exchange_n( | ||
| &value_, &e, new_val, true, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST); | ||
| #elif defined(ATOMIC_USE_MSVC_INTRINSICS) | ||
| const T old_val = | ||
| msvc::interlocked<T>::compare_exchange(&value_, new_val, expected_val); | ||
| return (old_val == expected_val); | ||
| #else | ||
| T e = expected_val; | ||
| return value_.compare_exchange_weak(e, new_val); | ||
| #endif | ||
| } | ||
|
|
||
| /// @brief Performs an atomic set operation. | ||
| /// | ||
| /// The value of the atomic object is unconditionally updated to the new | ||
| /// value. | ||
| /// | ||
| /// @param new_val The new value to write to the atomic object. | ||
| void store(const T new_val) { | ||
| #if defined(ATOMIC_USE_GCC_INTRINSICS) | ||
| __atomic_store_n(&value_, new_val, __ATOMIC_SEQ_CST); | ||
| #elif defined(ATOMIC_USE_MSVC_INTRINSICS) | ||
| (void)msvc::interlocked<T>::exchange(&value_, new_val); | ||
| #else | ||
| value_.store(new_val); | ||
| #endif | ||
| } | ||
|
|
||
| /// @returns the current value of the atomic object. | ||
| /// @note Be careful about how this is used, since any operations on the | ||
| /// returned value are inherently non-atomic. | ||
| T load() const { | ||
| #if defined(ATOMIC_USE_GCC_INTRINSICS) | ||
| return __atomic_load_n(&value_, __ATOMIC_SEQ_CST); | ||
| #elif defined(ATOMIC_USE_MSVC_INTRINSICS) | ||
| // TODO(m): Is there a better solution for MSVC? | ||
| return value_; | ||
| #else | ||
| return value_; | ||
| #endif | ||
| } | ||
|
|
||
| /// @brief Performs an atomic exchange operation. | ||
| /// | ||
| /// The value of the atomic object is unconditionally updated to the new | ||
| /// value, and the old value is returned. | ||
| /// | ||
| /// @param new_val The new value to write to the atomic object. | ||
| /// @returns the old value. | ||
| T exchange(const T new_val) { | ||
| #if defined(ATOMIC_USE_GCC_INTRINSICS) | ||
| return __atomic_exchange_n(&value_, new_val, __ATOMIC_SEQ_CST); | ||
| #elif defined(ATOMIC_USE_MSVC_INTRINSICS) | ||
| return msvc::interlocked<T>::exchange(&value_, new_val); | ||
| #else | ||
| return value_.exchange(new_val); | ||
| #endif | ||
| } | ||
|
|
||
| T operator=(const T new_value) { | ||
| store(new_value); | ||
| return new_value; | ||
| } | ||
|
|
||
| operator T() const { | ||
| return load(); | ||
| } | ||
|
|
||
| private: | ||
| #if defined(ATOMIC_USE_GCC_INTRINSICS) || defined(ATOMIC_USE_MSVC_INTRINSICS) | ||
| volatile T value_; | ||
| #else | ||
| std::atomic<T> value_; | ||
| #endif | ||
|
|
||
| ATOMIC_DISALLOW_COPY(atomic) | ||
| }; | ||
|
|
||
| } // namespace sync | ||
| } // namespace srt | ||
|
|
||
| // Undef temporary defines. | ||
| #undef ATOMIC_USE_GCC_INTRINSICS | ||
| #undef ATOMIC_USE_MSVC_INTRINSICS | ||
| #undef ATOMIC_USE_CPP11_ATOMIC | ||
|
|
||
| #endif // ATOMIC_ATOMIC_H_ |
Oops, something went wrong.