clipping with native resolution #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #112
@gmtoglia we just use downsampling just for getting potential size to give user is the image is big or not. We didn't do downsampling for clipping. But the last one was using wcs 1.0.0 that needs height and width, that why we put some value that i think it is lower than native resolution.
This PR is using wcs 2.0.1, with using just subset to get the native resolution
left : the wcs 1.0.0
right : this PR, using wcs 2.0.1
but the download time will be taking a bit longer, because of file is bigger too for native