Angular 9

[maguro]

No description provided.

[PowerKiKi]

There is a few commits that seems unrelated (maybe entirely unnecessary ?). Could you rebase and keep only the strictly necessary commit to Angular 9 upgrade so that the PR is easier to review please ?

From what I can see only b93ff1f and maybe 5b7af4d is really required.

[maguro]

From what I can see only b93ff1f and maybe 5b7af4d is really required.

iiuc, d50bdcd is needed as well. I can delete 05669a9, d933a62, and d79e3b8.

[PowerKiKi]

I am not sure what those sha correspond to anymore. But I still see commits related to yarn on Travis that I think are not necessary.

What was the commit d50bdcd ?

[PowerKiKi]

As a matter of fact yarn should not be used at all.

@HaithemMosbahi himself introduced package-lock.json first in 2017 in 6468127 and used it the last time not long ago in 2019 in 4f485d8.

On the other hand yarn.lock was introduce in 2018 in #33 and was not properly maintained, the last update being in 2018 in #44.

This shows that npm is the preferred package manager for this project and the yarn.lock file must be deleted. In addition this preference should be specified for Angular CLI by adding the following in angular.json:

 {
   "$schema": "./node_modules/@angular/cli/lib/config/schema.json",
+  "cli": {
+    "packageManager": "npm"
+   },

[maguro]

As a matter of fact yarn should not be used at all.

...

This shows that npm is the preferred package manager for this project and the yarn.lock file must be deleted. In addition this preference should be specified for Angular CLI by adding the following in angular.json:

 {
   "$schema": "./node_modules/@angular/cli/lib/config/schema.json",
+  "cli": {
+    "packageManager": "npm"
+   },

This should go into a different pull-request. I shall file one.

[maguro]

#87 removes yarn.

[odahcam]

#87 is merged, you can follow with this now.

[PowerKiKi]

I took the liberty to rebase this PR in #91. Hopefully this will help to get it merged.

[odahcam]

Let's follow there then, thanks.

[maguro]

Thanks for following up on this @PowerKiKi !

[odahcam]

Thank you too for the initial PR @maguro .