Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: pd.to_numeric(timedelta_scalar) raises TypeError #2

Closed
2 of 3 tasks
HagonChan opened this issue Oct 4, 2024 · 3 comments
Closed
2 of 3 tasks

BUG: pd.to_numeric(timedelta_scalar) raises TypeError #2

HagonChan opened this issue Oct 4, 2024 · 3 comments

Comments

@HagonChan
Copy link
Owner

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

import pandas as pd

pd.to_numeric(pd.Timedelta(1))

Issue Description

Getting a TypeError

Expected Behavior

For the example above, I should get the integer 1. That would match the behavior of pd.to_numeric(pd.Series(pd.Timedelta(1)))

Installed Versions

INSTALLED VERSIONS

commit : 0691c5c
python : 3.9.18
python-bits : 64
OS : Darwin
OS-release : 23.6.0
Version : Darwin Kernel Version 23.6.0: Wed Jul 31 20:48:52 PDT 2024; root:xnu-10063.141.1.700.5~1/RELEASE_ARM64_T6020
machine : arm64
processor : arm
byteorder : little
LC_ALL : None
LANG : en_US.UTF-8
LOCALE : en_US.UTF-8

pandas : 2.2.3
numpy : 1.26.3
pytz : 2023.3.post1
dateutil : 2.8.2
pip : 23.3.1
Cython : None
sphinx : None
IPython : 8.18.1
adbc-driver-postgresql: None
adbc-driver-sqlite : None
bs4 : None
blosc : None
bottleneck : None
dataframe-api-compat : None
fastparquet : None
fsspec : None
html5lib : None
hypothesis : None
gcsfs : None
jinja2 : None
lxml.etree : None
matplotlib : None
numba : None
numexpr : None
odfpy : None
openpyxl : None
pandas_gbq : None
psycopg2 : None
pymysql : None
pyarrow : None
pyreadstat : None
pytest : 8.3.2
python-calamine : None
pyxlsb : None
s3fs : None
scipy : None
sqlalchemy : None
tables : None
tabulate : None
xarray : None
xlrd : None
xlsxwriter : None
zstandard : None
tzdata : 2023.4
qtpy : None
pyqt5 : None

@HagonChan
Copy link
Owner Author

@acr-bot

Copy link

github-actions bot commented Oct 4, 2024

Here is a potential patch for reference:

diff --git a/pandas/core/tools/numeric.py b/pandas/core/tools/numeric.py
index 982851d..e02e694 100644
--- a/pandas/core/tools/numeric.py
+++ b/pandas/core/tools/numeric.py
@@ -189,6 +189,8 @@ def to_numeric(
             return float(arg)
         if is_number(arg):
             return arg
+        if isinstance(arg, Timedelta):  # Handle Timedelta
+            return arg.value
         is_scalars = True
         values = np.array([arg], dtype="O")
     elif getattr(arg, "ndim", 1) > 1:

This run costs 2.25 USD.

@HagonChan
Copy link
Owner Author

@acr-bot open-pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant