Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing import reported for non-doctrine annotations #199

Closed
mabar opened this issue Jun 7, 2020 · 1 comment
Closed

Missing import reported for non-doctrine annotations #199

mabar opened this issue Jun 7, 2020 · 1 comment

Comments

@mabar
Copy link

mabar commented Jun 7, 2020

From version 7.0.0 are reported missing imports, which is really nice for Doctrine annotations.

But I got reported non-doctrine annotations too (tested with 7.0.0 and 7.1.0). These should be imho ignored

Specifically all @phpstan-* and @psalm-* and also all from Doctrine ignore list (e.g. phpcsSuppress from Slevomat CS and dataProvider from PHPUnit are reported)
Haehnchen added a commit that referenced this issue Jun 7, 2020
@Haehnchen
fine tuning for annotation blacklist #199
02b9eff
Haehnchen added a commit that referenced this issue Jun 7, 2020
@Haehnchen
fine tuning for annotation blacklist #199
2ed6074
Haehnchen added a commit that referenced this issue Jun 7, 2020
@Haehnchen
fine tuning for annotation blacklist #199
b005711
Haehnchen added a commit that referenced this issue Jun 7, 2020
@Haehnchen
Merge pull request #200 from Haehnchen/feature/ignore-tags
14dd846 
fine tuning for annotation blacklist #199
@mabar
Copy link
Author

mabar commented Jun 8, 2020

Thanks for fast reaction, works perfectly fine now :)

@mabar mabar closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mabar