Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings on non-imported annotations #19

Open
mnapoli opened this issue Jun 25, 2014 · 10 comments
Open

Warnings on non-imported annotations #19

mnapoli opened this issue Jun 25, 2014 · 10 comments

Comments

@mnapoli
Copy link

mnapoli commented Jun 25, 2014

Depending on the configuration, you sometimes don't need to import annotations. However the plugin will add warnings on every not-imported annotation.

Would it be possible to disable this behavior, or make an option to disable it?

@Haehnchen
Copy link
Owner

so highlighting should be moved from annotation extension itself to inspections, so then it can be disabled.
also thinking of add whitelist ui in settings, also getting some failreports on drupal8

@drunken-monkey
Copy link

Would also be interested in seeing this fixed. As you say, this occurs quite often in Drupal 8. Having an inspection setting for this ("Warn about missing annotation imports") would be perfect!
Also, the warning has only the label "Import" and currently links to "General » Annotator" – the former a bit monosyllabic, the latter pretty confusing.

(See also: http://youtrack.jetbrains.com/issue/WI-24731)

@davidsielert
Copy link

Yeah I keep getting missing import as well whereas its not needed .. highly annoying as it highlights all the annotations..

@fgm
Copy link

fgm commented Nov 29, 2015

Ideally, the warning should be smart enough not to warn when the annotations are used in a Drupal 8 context, but to warn in more typical situations where they are needed. This probably needs a degree of cooperation with the Drupal support plugin.

@acelayawonnova
Copy link

Is there any update on this?

@sylus
Copy link

sylus commented Aug 15, 2016

Chiming in here as well to see if any progress been made. Happy to help if given some guidance :)

@chx
Copy link

chx commented Oct 24, 2016

The warning is created here, I would guess it should be possible to find out whether the inspection defined as localInspection groupPath="PHP" shortName="AnnotationMissingUseInspection" displayName="Missing Import" etc is enabled or not and change this to createInfoAnnotation when not.. A bit shooting in the dark as I am not particularly familiar with the class hierarchy of IDEA but getting there. @sylus is this enough to start?

@donquixote
Copy link

Given a scenario where both types of annotations are used:
How should this plugin decide which annotation needs importing and which does not?

@drunken-monkey
Copy link

drunken-monkey commented Aug 13, 2017

Given a scenario where both types of annotations are used:
How should this plugin decide which annotation needs importing and which does not?

If fixing this just for Drupal 8 (don't know whether import-less annotations exist in other projects and, if so, how common they are), it might be possible to either cooperate with the "Drupal" plugin, or to just look whether an annotation with that classname exists in some sub-namespace of \Drupal.
However, only a single person here has actually requested this, I think the much more typical case is just wanting to disable the warnings completely.
Also, currently I can't even reproduce the problem anymore. I have enabled the new PHP > Annotation > Missing Import inspection, but I still don't get any warnings for them. That actually seems like a new bug caused by this. But in general, with this setting now present, it looks like this is resolved as far as my requirements are concerned. So thanks a lot for that!

@donquixote
Copy link

only a single person here has actually requested this

Make this +1 :)
I am working on something where I would have a Drupal module which uses Drupal and non-Drupal annotations.

I think the much more typical case is just wanting to disable the warnings completely.

Problem is, those annotations that do require an import won't work without it. So for those I really would appreciate the warning.

or to just look whether an annotation with that classname exists in some sub-namespace of \Drupal

Maybe implement this for a start, and then if the question pops up again, make these namespaces somehow configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants