Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property suggestions (name + type + required) from @Attribute annotations #112

Closed
meyerbaptiste opened this issue Mar 22, 2018 · 1 comment
Closed

Add property suggestions (name + type + required) from @Attribute annotations #112

meyerbaptiste opened this issue Mar 22, 2018 · 1 comment
Labels
fixed

Comments

@meyerbaptiste
Copy link
Contributor

meyerbaptiste commented Mar 22, 2018 •
edited
Loading

Like class properties, property suggestions (name + type + required) should also work with @Attribute annotations.

See https://www.doctrine-project.org/projects/doctrine-annotations/en/latest/custom.html#attribute-types.

https://twitter.com/BigHaehnchen/status/976824933329317895
@meyerbaptiste meyerbaptiste mentioned this issue Mar 22, 2018
Merged
@teohhanhui teohhanhui mentioned this issue Oct 25, 2019
Merged
@Haehnchen Haehnchen mentioned this issue May 29, 2020
Closed
@Haehnchen
Copy link
Owner

Haehnchen commented May 29, 2020 •
edited
Loading

Workarounds in related tickets will fail with #139.

Supporting "@Attributes" should be done bevor a new release

 * @Attributes(
 *     @Attribute("accessControl", type="string"),
 *     @Attribute("accessControlMessage", type="string"),
 *     @Attribute("attributes", type="array"),
 *     @Attribute("cacheHeaders", type="array"),
 *     @Attribute("collectionOperations", type="array"),
 *     @Attribute("denormalizationContext", type="array"),
 *     @Attribute("deprecationReason", type="string"),
 *     @Attribute("description", type="string"),
 *     @Attribute("elasticsearch", type="bool"),

@Haehnchen Haehnchen added the todo label May 29, 2020
Haehnchen added a commit that referenced this issue May 29, 2020
@Haehnchen
Add property suggestions from Doctrine @Attribute annotations #112 (h…
c6509fc 
…ttps://www.doctrine-project.org/projects/doctrine-annotations/en/latest/custom.html#attribute-types)
Haehnchen added a commit that referenced this issue May 29, 2020
@Haehnchen
Add property suggestions from Doctrine @Attribute annotations #112 (h…
7c3dcff 
…ttps://www.doctrine-project.org/projects/doctrine-annotations/en/latest/custom.html#attribute-types)
Haehnchen added a commit that referenced this issue May 29, 2020
@Haehnchen
Add property suggestions from Doctrine @Attribute annotations #112 (h…
330cec5 
…ttps://www.doctrine-project.org/projects/doctrine-annotations/en/latest/custom.html#attribute-types)
Haehnchen added a commit that referenced this issue May 29, 2020
@Haehnchen
Add property suggestions from Doctrine @Attribute annotations #112 (h…
279e238 
…ttps://www.doctrine-project.org/projects/doctrine-annotations/en/latest/custom.html#attribute-types)
Haehnchen added a commit that referenced this issue May 30, 2020
@Haehnchen
Add property suggestions from Doctrine @Attribute annotations #112 (h…
bd4137f 
…ttps://www.doctrine-project.org/projects/doctrine-annotations/en/latest/custom.html#attribute-types)
Haehnchen added a commit that referenced this issue May 30, 2020
@Haehnchen
Add property suggestions from Doctrine @Attribute annotations #112 (h…
6efd59e 
…ttps://www.doctrine-project.org/projects/doctrine-annotations/en/latest/custom.html#attribute-types)
Haehnchen added a commit that referenced this issue May 30, 2020
@Haehnchen
Add property suggestions from Doctrine @Attribute annotations #112 (h…
5676967 
…ttps://www.doctrine-project.org/projects/doctrine-annotations/en/latest/custom.html#attribute-types)
Haehnchen added a commit that referenced this issue May 30, 2020
@Haehnchen
Merge pull request #183 from Haehnchen/feature/property-attribute
7a75efc 
Add property suggestions from Doctrine @Attribute annotations #112
@Haehnchen Haehnchen added fixed and removed todo labels May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Haehnchen @meyerbaptiste