Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pitchControl to indicate if a voice can be pitch adjusted #35

Closed
HadrienGardeur opened this issue Jun 17, 2024 · 0 comments
Closed
Assignees
Labels
voice-list Anything related to the JSON list of recommende voices

Comments

@HadrienGardeur
Copy link
Owner

As identified by @Falcosc in #34, some voices do not allow users to change their pitch.

With pitchControl, I'm adding a new boolean that will default to true but allow us to identify voices where this feature is unavailable.

As I mentioned in #34:

Using this new boolean, implementers could disable pitch control accordingly. It's better to disable pitch (or grey it out) than display a component that won't change anything for the user.

@HadrienGardeur HadrienGardeur added the voice-list Anything related to the JSON list of recommende voices label Jun 17, 2024
@HadrienGardeur HadrienGardeur self-assigned this Jun 17, 2024
@HadrienGardeur HadrienGardeur moved this from Ready to In progress in Best practices for read aloud Jun 17, 2024
HadrienGardeur added a commit that referenced this issue Jun 17, 2024
HadrienGardeur added a commit that referenced this issue Jun 18, 2024
@HadrienGardeur HadrienGardeur moved this from In progress to In review in Best practices for read aloud Jun 18, 2024
@HadrienGardeur HadrienGardeur moved this from In review to Done in Best practices for read aloud Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
voice-list Anything related to the JSON list of recommende voices
Projects
Development

No branches or pull requests

1 participant