Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add europe ccs2 request #283

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add europe ccs2 request #283

wants to merge 3 commits into from

Conversation

arteck
Copy link

@arteck arteck commented Sep 27, 2024

No description provided.

Copy link
Owner

@Hacksore Hacksore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also remove all he files from dist/ that were committed too.

@@ -2,7 +2,6 @@
node_modules/
.DS_Store
.rpt2_cache
dist/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this

rollup.config.js Outdated
@@ -13,15 +13,15 @@ export default {
{
format: 'cjs',
name: 'index',
file: 'dist/index.cjs',
file: 'j:/source/ioBroker/SmartHomeEnt/node_modules/bluelinky/dist/index.cjs',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this

rollup.config.js Outdated
exports: 'named',
banner: '/* @preserve bluelinky / MIT License / https://github.com/Hacksore/bluelinky */',
},
{
format: 'esm',
name: 'index',
exports: 'named',
file: 'dist/index.esm.js',
file: 'j:/source/ioBroker/SmartHomeEnt/node_modules/bluelinky/dist/index.esm.js',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this

@@ -165,6 +165,14 @@ export default class EuropeanVehicle extends Vehicle {

const fullStatus = cachedResponse.body.resMsg.vehicleStatusInfo;

const ccs2Response = this.updateRates(
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means we'd do one request for the old endpoint and another on for CCS2, do we want that?

I'm pretty out of the loop regarding the new API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants