Add tag category titles to filters #2015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hafizzle
commented
Jul 12, 2023
Hafizzle
commented
- Add tag category titles to filters
- Update tag title strings
Class change success text updates Add "learn more" -> navigate to FAQ
- Update Habitica Dialog destructive button color/improved accessibility - Change class "go back" text changed to "close" - Update Habitica Dialog message text size & color
- Order tags - Add "group" field to Tag
- Throw exception on consume if failed to consume (to continue flow/handle error) - Handle other potential errors (such as IOException or a exception thrown by billingClient.consumePurchase method that would not previously be handled
…ow-update Choose/Change Class selection flow updates
…itivity username case sensitivity
Add isUserSupport permission check
…se-fix Handle non-HTTPExceptions & continue flow if consume fails & no error
Match web implementation for tags / order tags
- Remove notification view immediately even before server response for better user experience - Update refreshViews method name to reflect usage
This allows all text to remain visible and the view itself to move (For smaller screens)
|
Can you take out the unrelated changes/reverts? Then I think it's ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.