Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Death Screen update to handle small screens or large text #1999

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Death Screen update to handle small screens or large text #1999

merged 1 commit into from
Jun 23, 2023

Conversation

Hafizzle
Copy link
Contributor

  • NestedScrollView added to handle smaller phone screen sizes
  • Set Buttons and Broken equipment text relative to bottom of screen (versus below text)

@Hafizzle
Death Screen update to handle small screens or large text
a3ab4a6 
NestedScrollView added to handle smaller phone screen sizes
Set Buttons and Broken equipment text relative to bottom of screen (versus below text)
@Hafizzle Hafizzle linked an issue Jun 20, 2023 that may be closed by this pull request
make death screen scrollable for small screens or large text #1998
Closed
@phillipthelen phillipthelen merged commit 372c6d6 into HabitRPG:version/4.2.3 Jun 23, 2023
@saraolson
Copy link
Collaborator

issues when testing this:

  • the text was cut off and made to scroll, rather than the whole view. would like all the text to remain visible and the view to move
  • i got a server error when tryin to press the button and it didnt work, then just left me on my task screen again. not sure what happened there?
    -the ghost and heart location got messed up, where the ghost got pushed too far down, making its tail stick out from the heart and hiding it's face. would want those elements to scale and move together (though this is lower priority)
screen-20230623-133219.3.mp4

@saraolson
Copy link
Collaborator

^ still the case when testing 7/7 (moved back to in progress)

@Hafizzle
Copy link
Contributor Author

@saraolson should now be fixed with f5159e1

@Hafizzle Hafizzle self-assigned this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipthelen phillipthelen Awaiting requested review from phillipthelen

@saraolson saraolson Awaiting requested review from saraolson

Assignees

@Hafizzle Hafizzle

Labels
Status: pr: with author: needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make death screen scrollable for small screens or large text
3 participants
@Hafizzle @saraolson @phillipthelen