Add new spectrum origin type #337
Conversation
As pointed out by reviewer of mzSpecLib, existing spectrum origin types are not adequate to classify this type of spectrum, commonly used for DIA analysis.
edeutsch
requested review from
mobiusklein,
javizca,
bittremieux and
henryhlam
There was a problem hiding this comment.
what about "reduced spectrum for peptide-centric scoring" or "transition list spectrum" or "selected known product ion spectrum"?
The definition is OK, except that it looks a bit run-on. May need a connector "whose" after the first comma.
There was a problem hiding this comment.
I agree that the definition is ok, the name takes a bit more effort to parse on its own though.
Maybe instead something like "selected fragment observed intensity spectrum"? The "selected" indicates that only a limited set of peaks are included, the "fragment" implicitly indicates that it's known fragments, thus theoretical m/z, and the "observed intensity" indicates that the intensity values are determined experimentally.
There was a problem hiding this comment.
+1 for "selected fragment observed intensity spectrum". It's succinct and conveys the concept and doesn't tie it to any particular domain.
There was a problem hiding this comment.
why not making it a bit more self explanatory? Unless we really want a short name: "Spectrum containing selected fragment ion peaks and experimental intensity"
There was a problem hiding this comment.
- "theoretical m/z observed intensity selected fragment spectrum"
- "selected fragment theoretical m/z observed intensity spectrum" +++
def: "Spectrum for which the peaks are limited to a subset of known product ions that are important for subsequent identification, whose m/z values are corrected to theoretical values, and intensity values are experimentally derived." [PSI:PI]
As pointed out by reviewer of mzSpecLib, existing spectrum origin types are not adequate to classify this type of spectrum, commonly used for DIA analysis.