Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Acetylation, Nitration, flavins #48

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Conversation

pmt706
Copy link
Member

@pmt706 pmt706 commented Dec 15, 2020

Attempts to address part of #47.

Adds "residue" to glyco terms (glucosylated --> glucosylated residue)

Nitration (+NO2) and Nitrosylation (+NO) were mishandled before, and this was addressed.

Fixed the Flavin-related terms in the chemical process tree, adding in masses at parent terms for FMN, FAD and Ribosyl-phosphoryl where appropriate

Fixed the acetylation tree, replacing generic acetylations with monoacetylations to match the Diff Mass/Formulae present. created diacetylation and homed that under a new mass-free term for acetylated residue with no number of instances.

Fixed a couple of typos too.

Attempts to address part of HUPO-PSI#47.

Adds "residue" to glyco terms (glucosylated --> glucosylated residue)

Nitration (+NO2) and Nitrosylation (+NO) were mishandled before, and this was addressed.

Fixed the Flavin-related terms in the chemical process tree, adding in masses at parent terms for FMN, FAD and Ribosyl-phosphoryl where appropriate

Fixed the acetylation tree, replacing generic acetylations with monoacetylations to match the Diff Mass/Formulae present.  created diacetylation and homed that under a new mass-free term for acetylated residue with no number of instances.

Fixed a couple of typos too.
@pmt706 pmt706 self-assigned this Dec 15, 2020
Copy link
Contributor

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@pmt706 pmt706 merged commit 3a8a4a5 into HUPO-PSI:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants