feature added #12, clickable links on output #39
Conversation
| @@ -305,8 +367,13 @@ class HydraConsole extends React.Component { | |||
| } | |||
| axios.post(this.agentEndpoint + '/send-command', getBody) | |||
| .then( (response) => { | |||
| let outputText = "" | |||
| if(response.data.length === 0) | |||
| outputText = String(JSON.stringify(response.data, this.jsonStringifyReplacer, 8)) | |||
There was a problem hiding this comment.
If response.data.length is 0, why would you stringify an empty string?
There was a problem hiding this comment.
Sure @xadahiya , actually it was because I was rendering the jsx incase its length was >0 so I stringify in case of empty response but thanks for correcting I will make changes accordingly
| resourcesIDs: resourcesIDs | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
Please add proper comments/docstrings to explain what each function does
There was a problem hiding this comment.
It would be great if you can do this for all the functions not just for the functions you wrote. 😄
There was a problem hiding this comment.
Sure thing to do, my plan was to add them to every function once it was reviewed! Thank you
| arr.push(<div className={classes.outputEntryDiv}></div>) | ||
| arr.push(<span className={classes.outputConsoleKey}>{key} :</span>) | ||
| if(key == "@id") | ||
| arr.push(<span className={classes.outputConsoleLink} |
There was a problem hiding this comment.
You should consider adding {} to improve readability and futureproofing (in case we want to add something else)
|
@xadahiya thanks for reviewing my work ! Will update with changes soon |
|
@xadahiya so I have added generic methos to support any kind of json response, and added the method to all the request response as asked, kindly review it, a proof of attachment from my side has been added, all the elements are jsx instead of string like earlier : |
…hod to /send-command route
What does this PR fixes/adds
Working proof is added here
