Cmake warning #230
Merged
Cmake warning #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For modern CMake use the new CMP0135 policy, i.e., use timestamps from extraction of tarballs Bump internal submodules to latest releases: nlohmman-json: 3.11.2 spdlog: 1.11.0
Now to 3.24, which is where the option to handle extract time timestamps was introduced
|
Oh err missus.... we need to update to this newer CMake on our CI platforms! |
Address the timestamp issue differently, using a query for the policy, which indicates a newer cmake, and only setting the policy if that test passes This allows us to be still compaible with much older cmake versions
|
Oh, I found out how to do this and stay compatible with older CMakes: if (POLICY CMP0135)
cmake_policy(SET CMP0135 NEW)
endif (POLICY CMP0135)Panic over! The new version fixes things for new CMakes and doesn't break things for older versions. |
|
We're using CMake version 3.24.3 in release 23.0/master these days @graeme-a-stewart. It's great that we can support both old and new CMake versions w/ the |
amete
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the extraction policy for the GTest externals - this is because of recent CMake changes in 3.24 (see https://cmake.org/cmake/help/latest/policy/CMP0135.html#policy:CMP0135).
I also took the opportunity to update our submodules to the latest releases:
N.B. I experimented with various options re. CMake policies, but the long and short of it is that adapting to this change means we need to have a minimum CMake version of 3.24, which is pretty new (August 2022). @amete - what's being used in ATLAS these days?
Probably it's also time for a minor release.
Closes #229