Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade main contract packege, audit fix and make token abstract #9

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Upgrade main contract packege, audit fix and make token abstract #9

wants to merge 16 commits into from

Conversation

duxor
Copy link

@duxor duxor commented Dec 11, 2020 •
edited
Loading

From #7

  • JS and SOL lint fix

From #8

  • Upgrade the OpenZeppelin package to the latest (sync implementation)
  • Audit fix for other packages
  • Fix linting: Code from this PR is included
  • Sync test with the implementation

Current changes

  • Make staking token abstract (create StakeableToken)
  • remove minting initial supply from abstraction

Motivation:

  • To increase scalability.
  • So, with this implementation, we will be able to use ERC20Capped and similar abstractions.

Note: https://github.com/duaraghav8/Ethlint

@duxor
refactor: fix sol lint issues
15cdcd8
@duxor
refactor: fix js related lint issues
7304dcc
@duxor
chore: upgrade main contract package to latest version and audit fix
e10a7ab
@duxor
chore: use npm instead of yarn - there are many issues with the yarn …
37c2c2f 
…and audit fix
@duxor
chore: test network is not available in latest truffle version, upgra…
39c25a7 
…de compiler
@duxor
chore: upgrade staking token with latest erc20 implementation
021c400
@duxor
chore: add validation to the remove stake method
0f3a034
@duxor
chore: upgrade solidity range at the migration contract
841214a
@duxor
chore: add required fields (name, symbol) to the contract deployment …
3c71bd6 
…process
@duxor
chore: replace expected fail messages in the contract test
8a3400e
@duxor
fix: staking token name and symbol
393421e
@duxor
chore: make abstract stakeable token
df1c3d3
@duxor duxor mentioned this pull request Dec 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@duxor