Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the _u variables #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Removed the _u variables #8

wants to merge 3 commits into from

Conversation

mvhulten
Copy link
Contributor

Instead of checking an intermediate variable and then setting the final variable, it is just as well to directly use the final variable.

Resolves: #4

Instead of checking an intermediate variable and then setting the final
variable, it is just as well to directly use the final variable.

Resolves: #4
@mvhulten mvhulten requested a review from s-poll December 12, 2024 08:21
dta/simres and dta/restart do not contain any tracked files and thus
existence cannot be assumed.  One cannot expect realpath(1) to work on
non-existing path, even as it does work on the GNU implementation.  The
fix is to append the basename(1) to the realpath(1) of the dirname(1).
Only caveat would be users using a different basename, but that is
really fringe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

variable name philosophy
1 participant