TSMP2-frontend-proposal: Handle relative path for model environment #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies using `build_tsmp2.sh` in scripts, when specifying a non-default model environment. In particular, the name of the TSMP2-directory is not a prerequisite for setting the model environment input after this PR.
s-poll
requested changes
Dec 2, 2024
There was a problem hiding this comment.
I would not like to merge this PR as it is also possible to use relative path without this modification just by putting a relative path to the call and this modification includes a restriction, which is not necessary.
In my view, an improvement would be to add a realpath so that the absolute path of the tsmp2_env is given in the log.
turns relative path inputs into absolute paths
|
I completely agree and changed the lines to that effect. This does exactly what I wanted now! |
jjokella
changed the title
s-poll
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies using
build_tsmp2.shin scripts, when specifying a non-default model environment.In particular, the name of the TSMP2-directory is not a prerequisite for setting the model environment input after this PR.