Fix COSMO coupled mode dummy values usage for restart #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-poll
added
bug
|
The change is a clear improvement of the current behavior. I will merge the pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, dummy values are used for COSMO in coupled mode until the first coupling time step. The dummy values are originally a bandaid for the halo-regions and contain typical values for a night in summer at mid-latitudes. The usage of the dummy values leads to diverging results between a restarted simulation of a coupled simulation with COSMO-CLM(-ParFlow) and an initial simulation. This is unintended, and due to the fix the dummy values will only be written at the initial step (
istep==0).The effect of the fix is biggest for restarted simulation with a large coupling time step between COSMO-CLM as well as simulation at noon and/or surface temperature (
tsf >>/<< 287.589 K)Caution: This code change will change the results of a restarted simulation. The restarted simulation will not be binary identical compared to an initial simulation, as one would need to read in the oasis fields of the initial run at restart time.