Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TSMP-PDAF to ParFlow>3.9 #153

Closed
jjokella opened this issue Jan 17, 2023 · 1 comment
Closed

Update TSMP-PDAF to ParFlow>3.9 #153

jjokella opened this issue Jan 17, 2023 · 1 comment
Labels
compile & build Compilation and build error, issues and surprises Parflow Issues relating to Parflow component or its coupling PDAF Issue relates to DA with PDAF versions Versioning of TSMP and topics related to component versions

Comments

@jjokella
Copy link
Contributor

Currently, TSMP-PDAF does not work with ParFlow>3.9. This is due to changes in ParFlow source files that are patched by TSMP-PDAF (thereby removing these changes) leading to inconsistencies in the patched source code.

By fixing the issue, ParFlow3.9 or lower cannot be used anymore. with tag 3.1.0MCTPDAF. For this, users will have to revert back to older revisions of TSMP-PDAF (f.e.: 5e7a0f5)
@jjokella jjokella added compile & build Compilation and build error, issues and surprises Parflow Issues relating to Parflow component or its coupling versions Versioning of TSMP and topics related to component versions PDAF Issue relates to DA with PDAF labels Jan 17, 2023
jjokella added a commit that referenced this issue Jan 17, 2023
@jjokella
intf_DA: Stepcount, Loopcount bugfix, related to #153
cab2630
jjokella added a commit that referenced this issue Jan 17, 2023
@jjokella
intf_DA: update PseudoAdvanceRichards to ParFlow3.12, related to #153
1672cfe 
keep PseudoAdvanceRichards up-to-date with AdvanceRichards of v3.12.0
@jjokella
Copy link
Contributor Author

With the new ParFlow version, the patch files, especially for the amps directory could be significantly simplified.
This is due to the introduction of the communicator amps_CommWorld in ParFlow that can largely be used as dacomm was used before in the patched files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compile & build Compilation and build error, issues and surprises Parflow Issues relating to Parflow component or its coupling PDAF Issue relates to DA with PDAF versions Versioning of TSMP and topics related to component versions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jjokella