Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optionSyntax.dest_none should unwrap its result #215

Closed
xrchz opened this issue Dec 9, 2014 · 2 comments
Closed

optionSyntax.dest_none should unwrap its result #215

xrchz opened this issue Dec 9, 2014 · 2 comments

Comments

@xrchz
Copy link
Member

xrchz commented Dec 9, 2014 

dest_none ``NONE`` = ``:'a option``

I think it would make more sense to just return

``:'a``
@konrad-slind
Copy link
Contributor

Agreed. Note that listSyntax.dest_nil does the right thing.

Konrad.

On Tue, Dec 9, 2014 at 6:36 AM, Ramana Kumar notifications@github.com
wrote:

dest_none NONE = :'a option

I think it would make more sense to just return

:'a

—
Reply to this email directly or view it on GitHub
#215.

@mn200
Copy link
Member

mn200 commented Dec 10, 2014

Yeah. Agreement here too. How much (if anything) breaks as a result?

@mn200 mn200 closed this as completed in a2d8c62 Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mn200 @xrchz @konrad-slind