Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS1.6 Lgagst Fix #4

Merged
merged 7 commits into from
Oct 8, 2022
Merged

CS1.6 Lgagst Fix #4

merged 7 commits into from
Oct 8, 2022

Conversation

khanghugo
Copy link
Contributor

Welp, it was like this before but I changed last minute long ago as I thought this would be better in the Main(). Welp, turns out it isn't that great. This should be final for CS1.6 hlstrafe change as it is fully matching bxt-strafe from bxt-rs.

@YaLTeR
Copy link
Contributor

YaLTeR commented Oct 8, 2022

If this breaks TASes then you need to bump max hlstrafe version and make this behavior conditional on the hlstrafe version

@khanghugo
Copy link
Contributor Author

khanghugo commented Oct 8, 2022

Should it be like that? Whoops, it doesn't compile.

@khanghugo
Copy link
Contributor Author

khanghugo commented Oct 8, 2022

Okay, this should be good then.

Some TASes desync, I guess it can do bit more. Just my imagination, but it doesn't hurt to check one more.

@khanghugo
Copy link
Contributor Author

This should be final, I wish so.

src/hlstrafe.cpp Outdated Show resolved Hide resolved
@YaLTeR
Copy link
Contributor

YaLTeR commented Oct 8, 2022

Did you verify that old scripts still work fine unchanged, and with hlstrafe_version 5 you get the right prediction?

@khanghugo
Copy link
Contributor Author

khanghugo commented Oct 8, 2022

Yes, I did try hlstrafe_version 4 for my previous scripts and all works fine. With hlstrafe_version 5, they will obviously desync but the part where lgagst needs its magic work correctly.

@YaLTeR YaLTeR merged commit 8cef892 into HLTAS:master Oct 8, 2022
@YaLTeR
Copy link
Contributor

YaLTeR commented Oct 8, 2022

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants