test: basic tests for static pages [1393] #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-s-nava
force-pushed
the
dschrashun/page-test-fixes
branch
from
a4ad0cf to
d1bf4a4
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 89.67% (-0.93% 🔻) |
842/939 |
| 🟡 | Branches | 71.79% | 224/312 |
| 🟢 | Functions | 86.57% (-1.33% 🔻) |
174/201 |
| 🟢 | Lines | 90.09% (-1.18% 🔻) |
791/878 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟡 | ... / not-found.tsx |
66.67% | 100% | 50% | 66.67% |
| 🟢 | ... / intlMocks.ts |
100% | 100% | 100% | 100% |
| 🟡 | ... / page.tsx |
71.43% | 100% | 50% | 71.43% |
| 🟡 | ... / page.tsx |
75% | 100% | 50% | 75% |
| 🟡 | ... / page.tsx |
77.78% | 100% | 50% | 77.78% |
Test suite run success
187 tests passing in 58 suites.
Report generated by 🧪jest coverage report action from d1bf4a4
mdragon
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1393
Time to review: 15 mins
Changes proposed
Adding basic page level tests for static pages
Context for reviewers
Based on previously existing tests that required some reworking due to code drift and support for internationalization: https://github.com/HHS/simpler-grants-gov/blob/2024.5.13-1/frontend/tests/pages/index.test.tsx
Testing instructions
npx jest tests/pages/page.test.tsxnpx jest tests/pages/research/page.test.tsxnpx jest tests/pages/process/page.test.tsxnpx jest tests/pages/not-found.test.tsxAdditional information