Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: HHS agencies not showing full slate of available Opportunities #3113

Closed
1 task done
margaretspring opened this issue Dec 5, 2024 · 3 comments
Closed
1 task done
Assignees

Comments

@margaretspring
Copy link
Collaborator

Summary

Narmada was testing out search & when she selected All the HHS agencies (3 listed in our search) only 13 Forecasted & Posted Opportunities showed up. On Grants.gov it's 1,329 opportunities.

Not sure if we're missing agencies or opportunities?

Reproducibility

I tried multiple times and saw the bug every time

How to reproduce the bug

Search for All HHS Forecasted & Posted Opportunities on Simpler.Grants.gov & Grants.gov... results are 13 vs 1329 (as of today).

Browser

None

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mdragon
Copy link
Collaborator

mdragon commented Dec 5, 2024

Yes, we are missing Agencies, and it's almost fixed #3057 and #3058

@mdragon mdragon assigned mdragon and unassigned mdragon and chouinar Dec 5, 2024
@chouinar
Copy link
Collaborator

chouinar commented Dec 5, 2024

Not exactly the same, but if you query by HHS that brings up a similar number:
https://simpler.grants.gov/search?query=HHS

At the time of writing this, I see 1328 results.


As a bit of additional sanity testing, I grabbed every agency that currently appears on grants.gov and queried the API directly with those:

{
  "filters": {
    "agency": {
      "one_of": ["HHS-CDC-NCHHSTP", "HHS-CDC-NCIRD", "HHS-CMS", "HHS-AHRQ", "HHS-ACF-ANA", "HHS-ACF-OPRE", "HHS-CDC-GHC", "HHS-ACF-OHS", "HHS-ARPAH", "HHS-OPHS", "HHS-ACF-OFVPS", "HHS-ACF-OCS", "HHS-CDC-HHSCDCERA", "HHS-ACF-FYSB", "HHS-ACF-OTIP", "HHS-CDC-NCEZID", "HHS-IHS", "HHS-OS-ASPR", "HHS-CDC-NCCDPHP", "HHS-CDC-NCBDDD", "HHS-NIH11", "HHS-ACF-ORR", "HHS-ACF-OFA", "HHS-FDA", "HHS-HRSA", "HHS-SAMHS-SAMHSA", "HHS-CDC-NCIPC", "HHS-ACF", "HHS-ACF-CB", "HHS-ACL", "HHS-OS-ONC"]
    },
    "opportunity_status": {
      "one_of": [
        "forecasted",
        "posted"
      ]
    }
  },
  "pagination": {
    "order_by": "opportunity_id",
    "page_offset": 1,
    "page_size": 25,
    "sort_direction": "descending"
  }
}

And also got 1328 results:

  "pagination_info": {
    "order_by": "opportunity_id",
    "page_offset": 1,
    "page_size": 25,
    "sort_direction": "descending",
    "total_pages": 54,
    "total_records": 1328
  }

@chouinar
Copy link
Collaborator

chouinar commented Dec 5, 2024

@mdragon - if we want to set a static config, this should be the right format for the frontend / contain agencies that have at least one opportunity.
agency_data.json

@mdragon mdragon closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2024
mdragon added a commit that referenced this issue Dec 9, 2024
#3150)

## Summary
Fixes #3058

### Time to review: __1 mins__

## Changes proposed
Pasting in an [updated JSON
extract](#3113 (comment))
that is complete for all Agencies listing Opportunities currently. This
will move to be a live API call in a follow-up ticket.

## Context for reviewers
Testing by validating that the filter list for Agencies is much more
extensive now. Because we're using a static list of Prod Agencies we
can't actually test that the filters work and return Opportunities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants