Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Split top-level docker-compose file into a front-end and back-end file to make running each individually simpler #1510

Closed
1 task
chouinar opened this issue Mar 20, 2024 · 0 comments · Fixed by #1513
Assignees
Labels
project: grants.gov Grants.gov Modernization tickets

Comments

@chouinar
Copy link
Collaborator

Summary

https://github.com/HHS/simpler-grants-gov/blob/main/docker-compose.yml starts up:

  • The API
  • The DB for the API
  • The Next JS app
  • Storybook

But if I'm an API developer, I likely don't need those last two most of the time, and vice-versa for the front-end developers. While running them altogether should be possible / easy, we should also make running them separately easy. We can do this by using https://docs.docker.com/compose/multiple-compose-files/include/

We make two docker-compose files, one in the frontend, and one in the API folder. Then we make a top-level one that includes both of those use include.

Acceptance criteria

  • Docker-compose files created and able to start up the API/frontend without the other uneventfully
@chouinar chouinar added the project: grants.gov Grants.gov Modernization tickets label Mar 20, 2024
@chouinar chouinar added this to the Technical improvements milestone Mar 20, 2024
@rylew1 rylew1 moved this from Icebox to In Progress in Simpler.Grants.gov Product Backlog Mar 20, 2024
@rylew1 rylew1 self-assigned this Mar 20, 2024
rylew1 added a commit that referenced this issue Mar 21, 2024
## Summary
Fixes #1510

## Changes proposed
- Move `nextjs` and `storybook` service to
`./frontend/docker-compose.yml`
- Move `grants-api` and `grants-db` service to
`./api/docker-compose.yml`
- Top level `./docker-compose.yml`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Development

Successfully merging a pull request may close this issue.

2 participants