Skip to content

Commit

Permalink
Update footer X/Twitter link (#2282)
Browse files Browse the repository at this point in the history
## Summary
Fixes #1588 

### Time to review: <5min

## Changes proposed
Update twitter link in footer to 'X': logo, hint/name, and link route
itself

## Additional information
<img width="628" alt="Screenshot 2024-09-30 at 3 25 25 PM"
src="https://github.com/user-attachments/assets/3bf0c499-4393-421d-9cb1-24c07c84de53">
  • Loading branch information
emilycnava authored Oct 1, 2024
1 parent ac2c5ba commit ee9fa3f
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions frontend/src/components/Footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ const Footer = () => {

const links = [
{
href: ExternalRoutes.GRANTS_TWITTER,
name: t("link_twitter"),
icon: "twitter",
href: ExternalRoutes.GRANTS_X_TWITTER,
name: t("link_x_twitter"),
icon: "x",
},
{
href: ExternalRoutes.GRANTS_YOUTUBE,
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/constants/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const ExternalRoutes = {
GRANTS_NEWSLETTER:
"https://www.grants.gov/web/grants/connect/newsletter-archive.html",
GRANTS_RSS: "https://grants.gov/connect/rss-feeds",
GRANTS_TWITTER: "https://twitter.com/grantsdotgov",
GRANTS_X_TWITTER: "https://x.com/grantsdotgov",
GRANTS_YOUTUBE: "https://www.youtube.com/user/GrantsGovUS",
GRANTS_BLOG: "https://grantsgovprod.wordpress.com/",
HHS: "https://www.hhs.gov",
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/i18n/messages/en/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ export const messages = {
agency_contact_center: "Grants.gov Program Management Office",
telephone: "1-877-696-6775",
return_to_top: "Return to top",
link_twitter: "Twitter",
link_x_twitter: "X (Twitter)",
link_youtube: "YouTube",
link_github: "Github",
link_rss: "RSS",
Expand Down
6 changes: 3 additions & 3 deletions frontend/tests/components/Footer.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ describe("Footer", () => {
it("Renders social links", () => {
render(<Footer />);

const twitter = screen.getByTitle("Twitter");
const x_twitter = screen.getByTitle("X (Twitter)");
const youtube = screen.getByTitle("YouTube");
const github = screen.getByTitle("Github");
const rss = screen.getByTitle("RSS");
const newsletter = screen.getByTitle("Newsletter");
const blog = screen.getByTitle("Blog");

expect(twitter).toBeInTheDocument();
expect(twitter).toHaveAttribute("href", ExternalRoutes.GRANTS_TWITTER);
expect(x_twitter).toBeInTheDocument();
expect(x_twitter).toHaveAttribute("href", ExternalRoutes.GRANTS_X_TWITTER);

expect(youtube).toBeInTheDocument();
expect(youtube).toHaveAttribute("href", ExternalRoutes.GRANTS_YOUTUBE);
Expand Down

1 comment on commit ee9fa3f

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage report for ./frontend

St.
Category Percentage Covered / Total
🟢 Statements 88.47% 928/1049
🟡 Branches 73.49% 244/332
🟢 Functions 84.11% 180/214
🟢 Lines 88.75% 868/978

Test suite run success

188 tests passing in 59 suites.

Report generated by 🧪jest coverage report action from ee9fa3f

Please sign in to comment.