Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coding/non-coding identity #169

Merged
merged 3 commits into from
Aug 11, 2024
Merged

coding/non-coding identity #169

merged 3 commits into from
Aug 11, 2024

Conversation

jtdendunnen
Copy link
Contributor

as discussed in HVNC meeting, there should be no difference in the description of this rule for coding and non-coding reference sequences

as discussed in HVNC meeting, there should be no difference in the description of this rule for coding and non-coding reference sequences
@ifokkema
Copy link
Collaborator

@jfjlaros I believe this was the sentence that you mentioned, correct?

@jfjlaros
Copy link
Collaborator

Indeed.

Additionally, instead of using "reference sequence", I would propose to use something like "transcript annotation", e.g., "it is not allowed to describe variants in nucleotides beyond the boundaries of the annotated transcript."

@ifokkema
Copy link
Collaborator

Additionally, instead of using "reference sequence", I would propose to use something like "transcript annotation", e.g., "it is not allowed to describe variants in nucleotides beyond the boundaries of the annotated transcript."

I believe, however, that this remark is meant to exclude NR_123456.1:n.100+10del. If so, the current statement is fine. Although it seems not to be allowed to describe NC_000001.10(NR_123456.1):n.-100del either, I do not believe that is what is meant here. Perhaps we should update the sentence and clarify what is meant here; intronic positions (that then require the addition of a genomic reference sequence) or anything beyond the transcript boundaries (even when used in combination with a genomic reference sequence). If both are meant, this should be clarified.

@jfjlaros
Copy link
Collaborator

jfjlaros commented Apr 17, 2024

Indeed, it should never be allowed to address a coordinate outside of the reference sequence, regardless of the coordinate system used. Perhaps we should make this a general remark.

If this was indeed the intention, then addressing genomic coordinates beyond the boundaries of the transcript was never a rule in the first place. If this is the case, then I would prefer a general remark and dropping the comments in the "coding" and "noncoding" sections.

Copy link
Collaborator

@ahwagner ahwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I follow this change; if we are disallowing representation of variants outside of a specified reference (which I think is a good thing), when would we use +/- syntax? I am assuming this is still intended to be used since it is not being removed in this PR.

Is there an associated discussion / issue thread to provide context for what this PR is addressing?

@jfjlaros
Copy link
Collaborator

when would we use +/- syntax?

When we use a genomic reference sequence.

For example, description NG_012337.3(NM_003002.4):c.52+100del is valid because position c.52+100 indexes a G at position 5213 in the reference sequence of NG_012337.3.
On the other hand, description NM_003002.4:c.52+100del is invalid since c.52+100 does not index anything in the reference sequence of NM_003002.4.

@reece reece merged commit d87ca6c into main Aug 11, 2024
1 check passed
@reece reece deleted the jtdendunnen-patch-4 branch August 11, 2024 23:48
Copy link
Collaborator

@ahwagner ahwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the specific requested change, it was noted that this edited text continues to conflict with other parts of the website, which should now be updated to match this.

docs/background/numbering.md Show resolved Hide resolved
@ifokkema
Copy link
Collaborator

ifokkema commented Oct 7, 2024

In addition to the specific requested change, it was noted that this edited text continues to conflict with other parts of the website, which should now be updated to match this.

Fixed in b167111. I will open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants