-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coding/non-coding identity #169
Conversation
as discussed in HVNC meeting, there should be no difference in the description of this rule for coding and non-coding reference sequences
@jfjlaros I believe this was the sentence that you mentioned, correct? |
Indeed. Additionally, instead of using "reference sequence", I would propose to use something like "transcript annotation", e.g., "it is not allowed to describe variants in nucleotides beyond the boundaries of the annotated transcript." |
I believe, however, that this remark is meant to exclude |
Indeed, it should never be allowed to address a coordinate outside of the reference sequence, regardless of the coordinate system used. Perhaps we should make this a general remark. If this was indeed the intention, then addressing genomic coordinates beyond the boundaries of the transcript was never a rule in the first place. If this is the case, then I would prefer a general remark and dropping the comments in the "coding" and "noncoding" sections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow this change; if we are disallowing representation of variants outside of a specified reference (which I think is a good thing), when would we use +/- syntax? I am assuming this is still intended to be used since it is not being removed in this PR.
Is there an associated discussion / issue thread to provide context for what this PR is addressing?
When we use a genomic reference sequence. For example, description NG_012337.3(NM_003002.4):c.52+100del is valid because position |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the specific requested change, it was noted that this edited text continues to conflict with other parts of the website, which should now be updated to match this.
Fixed in b167111. I will open a PR. |
as discussed in HVNC meeting, there should be no difference in the description of this rule for coding and non-coding reference sequences