Remove unneeded Try and Catch

HERMES-SOC · Aug 14, 2023 · d35861c · d35861c
1 parent 167204b
commit d35861c
Showing 1 changed file with 18 additions and 33 deletions.
diff --git a/lambda_function/src/file_processor/file_processor.py b/lambda_function/src/file_processor/file_processor.py
@@ -240,41 +240,26 @@ def _process_file(self) -> None:
                             filename=new_file_path,
                             file_key=new_file_key,
                         )
-                        try:
-                            if self.slack_client:
-                                # Send Slack Notification
-                                send_pipeline_notification(
-                                    slack_client=self.slack_client,
-                                    slack_channel=self.slack_channel,
-                                    path=new_file_path,
-                                    alert_type="processed",
-                                )
-                        except Exception as e:
-                            log.error(
-                                {
-                                    "status": "ERROR",
-                                    "message": f"Error when logging to Slack: {e}",
-                                }
+
+                        if self.slack_client:
+                            # Send Slack Notification
+                            send_pipeline_notification(
+                                slack_client=self.slack_client,
+                                slack_channel=self.slack_channel,
+                                path=new_file_path,
+                                alert_type="processed",
                             )
 
-                        try:
-                            if self.timestream_client:
-                                # Log to timeseries database
-                                log_to_timestream(
-                                    timestream_client=self.timestream_client,
-                                    action_type="PUT",
-                                    file_key=self.file_key,
-                                    new_file_key=new_file_key,
-                                    source_bucket=destination_bucket,
-                                    destination_bucket=destination_bucket,
-                                    environment=self.environment,
-                                )
-                        except Exception as e:
-                            log.error(
-                                {
-                                    "status": "ERROR",
-                                    "message": f"Error when logging to Timestream: {e}",
-                                }
+                        if self.timestream_client:
+                            # Log to timeseries database
+                            log_to_timestream(
+                                timestream_client=self.timestream_client,
+                                action_type="PUT",
+                                file_key=self.file_key,
+                                new_file_key=new_file_key,
+                                source_bucket=destination_bucket,
+                                destination_bucket=destination_bucket,
+                                environment=self.environment,
                             )
 
                 except ValueError as e: