Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging fix and namespace fix #3

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Logging fix and namespace fix #3

merged 3 commits into from
Oct 28, 2022

Conversation

ehsteve
Copy link
Member

@ehsteve ehsteve commented Oct 13, 2022

No description provided.

@ehsteve ehsteve requested a review from dbarrous October 13, 2022 19:04
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #3 (0dff63e) into main (e35a91e) will increase coverage by 11.69%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##             main       #3       +/-   ##
===========================================
+ Coverage   77.77%   89.47%   +11.69%     
===========================================
  Files           2        3        +1     
  Lines          18       19        +1     
===========================================
+ Hits           14       17        +3     
+ Misses          4        2        -2     
Impacted Files Coverage Δ
hermes_merit/calibration/calibration.py 86.66% <80.00%> (+13.33%) ⬆️
hermes_merit/calibration/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@dbarrous dbarrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and tested all of the PRs and they work as they are working as they should. As discussed last week the logs are getting propagated as they should, so PR LGTM!

Screenshot of test:
version-debug

@ehsteve ehsteve merged commit e719623 into HERMES-SOC:main Oct 28, 2022
@ehsteve ehsteve deleted the logging branch October 28, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants