-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: ability to pre-fix the BCRS coordinates #97
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 97.82% 97.85% +0.02%
==========================================
Files 21 21
Lines 828 838 +10
Branches 89 93 +4
==========================================
+ Hits 810 820 +10
Misses 9 9
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Thanks @steven-murray
This adds the option to pre-set the
_bcrs
coordinates in the ERFA coord manager. This is useful if using the optionupdate_bcrs_every=np.inf
, so that the BCRS matrix is set outside thesetup()
(which is called inside multiprocessing tasks).