Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: ability to pre-fix the BCRS coordinates #97

Merged
merged 9 commits into from
Oct 29, 2024
Merged

Conversation

steven-murray
Copy link
Contributor

This adds the option to pre-set the _bcrs coordinates in the ERFA coord manager. This is useful if using the option update_bcrs_every=np.inf, so that the BCRS matrix is set outside the setup() (which is called inside multiprocessing tasks).

@steven-murray steven-murray self-assigned this Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (8b97962) to head (5c7dc96).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   97.82%   97.85%   +0.02%     
==========================================
  Files          21       21              
  Lines         828      838      +10     
  Branches       89       93       +4     
==========================================
+ Hits          810      820      +10     
  Misses          9        9              
  Partials        9        9              
Flag Coverage Δ
unittests 97.25% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tyler-a-cox tyler-a-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks @steven-murray

@steven-murray steven-murray merged commit 2994591 into main Oct 29, 2024
13 checks passed
@steven-murray steven-murray deleted the prefix-bcrs branch October 29, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants