Fix progress #56
Merged
Fix progress #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last iteration will show negative date for Expected Time, e.g `Expected Time: 0:00:08.712192 [-1 day, 23:59:59.999967 remaining]`. This is just because the expected estimate is negative.
In previous comment, the unit was hard-coded as 1e-6, but that is not always the case.
steven-murray
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs in the cli and progress reporting. The last commit pin
pyuvsim>=1.25which might not actually be needed for the changes here, but it is probably good to keep if we intend to merge theprogressbranch to be used tomemory-profilingupdate onhera_sim