Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added import error handling a little more robustly for gpu initializa… #53

Merged
merged 3 commits into from
Oct 16, 2022

Conversation

AaronParsons
Copy link
Contributor

…tion errors
This fixes a specific issue where GPUs can go MIA (but all associated libraries are installed) and this break imports for many other packages.

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Base: 100.00% // Head: 99.18% // Decreases project coverage by -0.81% ⚠️

Coverage data is based on head (90dd643) compared to base (1e12ca5).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 90dd643 differs from pull request most recent head 9bf058d. Consider uploading reports for the commit 9bf058d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #53      +/-   ##
===========================================
- Coverage   100.00%   99.18%   -0.82%     
===========================================
  Files            8        8              
  Lines          488      492       +4     
  Branches        73       73              
===========================================
  Hits           488      488              
- Misses           0        4       +4     
Impacted Files Coverage Δ
src/vis_cpu/gpu.py 98.02% <0.00%> (-1.98%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AaronParsons
Copy link
Contributor Author

Suggest merging even though code coverage decreases (hard to test this mode, but have tested in on my computer)

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AaronParsons.

@AaronParsons AaronParsons merged commit 58b25a2 into main Oct 16, 2022
@AaronParsons AaronParsons deleted the fix_cublas_import_error branch October 16, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants