Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to not check autos #291

Merged
merged 2 commits into from
Dec 28, 2023
Merged

feat: add option to not check autos #291

merged 2 commits into from
Dec 28, 2023

Conversation

steven-murray
Copy link
Contributor

Adds an option not to check autos at all, since this takes ~1min for a simulation that takes <2min.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4f8612a) 92.89% compared to head (395de2c) 92.92%.
Report is 1 commits behind head on main.

Files Patch % Lines
hera_sim/visibilities/cli.py 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   92.89%   92.92%   +0.03%     
==========================================
  Files          24       24              
  Lines        3222     3223       +1     
  Branches      705      705              
==========================================
+ Hits         2993     2995       +2     
  Misses        126      126              
+ Partials      103      102       -1     
Flag Coverage Δ
unittests 92.89% <95.45%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@piyanatk piyanatk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the auto checking and compression should be done by rank 0 process, right? Otherwise, look good, Steven.

hera_sim/visibilities/cli.py Show resolved Hide resolved
@steven-murray steven-murray merged commit 30f965e into main Dec 28, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants