Various codeql updates #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed HDF5_VOL_CONNECTOR settings for the tests * update the README * lower test timeout * fixed critical codeQL items
* fixed codeQL issues * Committing clang-format changes * codeQL fixes * Committing clang-format changes * syntax * Fix code scanning alert no. 292: Unbounded write Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Committing clang-format changes * updates * Committing clang-format changes --------- Co-authored-by: github-actions <github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
src/H5LS.c
Outdated
| "Supported options: SSD|BURST_BUFFER|MEMORY|GPU\n", | ||
| type); | ||
|
|
||
| size_t copy_len = strlcpy(truncated_msg, type, sizeof(truncated_msg)); |
There was a problem hiding this comment.
Do we care too much about using non-standard C?
There was a problem hiding this comment.
Yes, I fixed to use snprintf
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
zhenghh04
previously approved these changes
Feb 11, 2025
jhendersonHDF
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly addressing unbounded writes and unused variables.