Sync develop changes March 25 - March 28 to hdf5_1_14 #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#4236) Both H5Dchunk_iter() and H5Dget_chunk_info(_by_coord)() did not take the size of the user block into account when reporting addresses. Since the HDFGroup#1 use of these functions is to root around in the file for the raw data, this is kind of a problem. Fixes GitHub issue HDFGroup#3003
We previously tried removing the per-tool invocation of the Autotools and instead simply invoked autoreconf (PR HDFGroup#1906). This was reverted when it turned out that the NAG Fortran compiler had trouble with an undecorated -shared linker flag. It turns out that this is due to a bug in libtool 2.4.2 and earlier. Since this version of libtool is over a decade old, we're un-reverting the change. We've added a release note for anyone who has to build from source on elderly platforms. Fixes HDFGroup#1343
* Move conversion path free logic to helper function
* Remove an error check regarding large cache objects In PR#4231 an assert() call was converted to a normal HDF5 error check. It turns out that the original assert() was added by a developer as a way of being alerted that large cache objects existed instead of as a guard against incorrect behavior, making it unnecessary in either debug or release builds. The error check has been removed. * Update RELEASE.txt
-fsanitize=memory is almost useless without using -fsanitize-memory-track-origins=2 and we shoud probably add -fno-optimize-sibling-calls as well.
* corrected type for MPI_*_f2c APIs * fixed return type of callback * reset compilation flags of logical test program
* Clean up test/cmpd_dtransform.c * Fix uninitialized memory warning from sanitizers * FAIL_STACK_ERROR --> TEST_ERROR * Emit output * Delete test file when done * Fix typo * H5Fdelete() --> remove()
* Update H5_IS_BUFFER_OVERFLOW to account for 'size' of 0 * Invert a few checks to avoid function call
* turn warnings to errors in fortran configure test * Intel fortran test fix
When the H5_addr_overlap macro was updated to use H5_RANGE_OVERLAP, it failed to take into account that H5_RANGE_OVERLAP expects the range to be inclusive. This lead to an assertion failure in H5MM_memcpy due to a memcpy operation on overlapping memory. This has been fixed by subtracting 1 from the calculated high bound values passed to H5_RANGE_OVERLAP
H5PB_read previously did not account for the fact that the size of the read it's performing could overflow the page buffer pointer, depending on the calculated offset for the read. This has been fixed by adjusting the size of the read if it's determined that it would overflow the page.
lrknox
requested review from
brtnfld,
derobins,
epourmal,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
mattjala
as code owners
doxygen/dox/ExamplesAPI.dox
Outdated
| <td><a href="https://github.com/HDFGroup/hdf5/blob/hdf5_1_14/HDF5Examples/C/H5T/tfiles/112/h5ex_t_bit.ddl">h5ex_t_bit.ddl</a></td> | ||
| <td><a href="https://github.com/HDFGroup/hdf5/blob/hdf5_1_14/HDF5Examples/C/H5T/tfiles/16/h5ex_t_bit.tst">h5ex_t_bit.tst</a></td> | ||
| <td><a href="https://github.com/HDFGroup/hdf5/blob/hdf5_1_14/HDF5Examples/C/H5T/tfiles/18/h5ex_t_bit.ddl">h5ex_t_bit.ddl</a></td> | ||
| >>>>>>> 42f9d24... Correct reference copy for 16 API (#4244) |
doxygen/dox/ExamplesAPI.dox
Outdated
| <td><a href="https://github.com/HDFGroup/hdf5/blob/hdf5_1_14/HDF5Examples/C/H5T/tfiles/112/h5ex_t_cmpdatt.ddl">h5ex_t_cmpdatt.ddl</a></td> | ||
| <td><a href="https://github.com/HDFGroup/hdf5/blob/hdf5_1_14/HDF5Examples/C/H5T/tfiles/16/h5ex_t_cmpdatt.tst">h5ex_t_cmpdatt.tst</a></td> | ||
| <td><a href="https://github.com/HDFGroup/hdf5/blob/hdf5_1_14/HDF5Examples/C/H5T/tfiles/18/h5ex_t_cmpdatt.ddl">h5ex_t_cmpdatt.ddl</a></td> | ||
| >>>>>>> 42f9d24... Correct reference copy for 16 API (#4244) |
jhendersonHDF
approved these changes
Mar 29, 2024
lrknox
commented
Mar 29, 2024
byrnHDF
approved these changes
Mar 29, 2024
lrknox
commented
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.