Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add actions that should pass #142

Closed
wants to merge 55 commits into from
Closed

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Jan 17, 2023

Before you make too many changes, test them with these Actions.
Don't release 4.2.16 until they all pass.

@byrnHDF
Copy link
Collaborator

byrnHDF commented Jan 18, 2023

Can we just combine these into two files - one for aarch and one for bsd.

@hyoklee
Copy link
Member Author

hyoklee commented Jan 18, 2023

Can we just combine these into two files - one for aarch and one for bsd.

@byrnHDF , good idea but will it give 2 status badges?
I split them to have multiple badges and identify build errors easily:

https://github.com/hyoklee/hdf4

@byrnHDF
Copy link
Collaborator

byrnHDF commented Jan 18, 2023

Actually, it is easier to see what failed when everything is in one file. And tests only run when there is a change, so there is an exact reason for the failure. We have a policy that all must pass to merge anyway.
However there is some merit in separate files for platforms, showing what platforms have been tested.

@derobins
Copy link
Member

It looks like the Autotools have trouble with ARM. Can we bring over the tests that pass so we're at least checking for that on each commit? We can set up a separate PR for the platforms and compilers that fail.

@derobins derobins added Component - Testing Test code, GitHub workflows Type - Improvement Improvements that don't add a new feature or functionality Priority - 1. High 🔼 These are important issues that should be resolved in the next release labels May 3, 2023
hyoklee and others added 7 commits June 6, 2023 13:45
A couple of tests in tncvarget would emit messages about reading bad
values, but would not actually fail the test. This change fixes
all the -Wshadowed warnings, fixes the array code so the tests
pass, and properly check the number of errors so the tests will
fail on errors.

Note that the library did not actually do the wrong thing - these
were just poorly-coded tests.
@hyoklee hyoklee closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Testing Test code, GitHub workflows Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants