-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add actions that should pass #142
Conversation
Can we just combine these into two files - one for aarch and one for bsd. |
@byrnHDF , good idea but will it give 2 status badges? |
Actually, it is easier to see what failed when everything is in one file. And tests only run when there is a change, so there is an exact reason for the failure. We have a policy that all must pass to merge anyway. |
It looks like the Autotools have trouble with ARM. Can we bring over the tests that pass so we're at least checking for that on each commit? We can set up a separate PR for the platforms and compilers that fail. |
A couple of tests in tncvarget would emit messages about reading bad values, but would not actually fail the test. This change fixes all the -Wshadowed warnings, fixes the array code so the tests pass, and properly check the number of errors so the tests will fail on errors. Note that the library did not actually do the wrong thing - these were just poorly-coded tests.
Fix failing netcdf tests
Before you make too many changes, test them with these Actions.
Don't release 4.2.16 until they all pass.