Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated IconButton component #26

Merged
merged 20 commits into from
Aug 29, 2024
Merged

Updated IconButton component #26

merged 20 commits into from
Aug 29, 2024

Conversation

kristineapallaHCL
Copy link
Contributor

@kristineapallaHCL kristineapallaHCL commented Aug 27, 2024 •
edited
Loading

Screen Shot 2024-08-27 at 10 21 08 PM

rubyannmatias
rubyannmatias reviewed Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@rubyannmatias rubyannmatias left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon button medium visual test shows the medium when hovered/focused/etcetera does not have the space on the side (margin/padding right???) it has when size is small.

Is this expected by UIUX? Just curious about the difference in small & medium looks

Screenshot 2024-08-28 at 1 04 08 AM

HanjoHagemeierHCL
HanjoHagemeierHCL approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@HanjoHagemeierHCL HanjoHagemeierHCL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks from a code perspective good to me ....

@felix-hcl felix-hcl merged commit 846f235 into HCL-TECH-SOFTWARE:main Aug 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubyannmatias rubyannmatias rubyannmatias approved these changes

@HanjoHagemeierHCL HanjoHagemeierHCL HanjoHagemeierHCL approved these changes

@felix-hcl felix-hcl Awaiting requested review from felix-hcl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristineapallaHCL @HanjoHagemeierHCL @rubyannmatias @felix-hcl