RHELMISC-9548: Differentiate GUI and CORE platforms on the ISO config #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Jedoku
force-pushed
the
RHELMISC-9548-Differentiate-GUI-and-CORE-platforms-on-the-ISO-config-level
branch
from
55ebfa2 to
8e015e6
Compare
kostyanf14
requested review from
akihikodaki and
kostyanf14
and removed request for
akihikodaki
akihikodaki
reviewed
Mar 19, 2025
Jedoku
force-pushed
the
RHELMISC-9548-Differentiate-GUI-and-CORE-platforms-on-the-ISO-config-level
branch
from
8e015e6 to
7b05c7f
Compare
akihikodaki
requested changes
Mar 19, 2025
lib/engines/hckinstall/iso.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "Win2019x64": { | |||
| "Win2022x64_bios_CORE": { | |||
There was a problem hiding this comment.
- It's 2019, not 2022.
- I think the
_COREsuffix should be removed for consistency with the names of platforms that use it.
There was a problem hiding this comment.
in any case, this is just an example without real product_key this file does not work)
… level Signed-off-by: Vitalii Chulak <vitalii@daynix.com>
Jedoku
force-pushed
the
RHELMISC-9548-Differentiate-GUI-and-CORE-platforms-on-the-ISO-config-level
branch
from
7b05c7f to
e71efe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.