Delegate to :ssl for setopts/2 when transport is tls #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starbelly
force-pushed
the
delegate-to-ssl-for-setopts
branch
from
227e1e1 to
1e42e98
Compare
Previously we always called `:inet.setopts/2` when a timeout was detected
to set `{linger, {true, 0}}` to immediately tear down the socket before
closing the connection. In doing so and in the case of tls the sslsocket
structure gets passed to `:prim_inet.setopts/2` where the first argument
is expected to be a port identifier.
starbelly
force-pushed
the
delegate-to-ssl-for-setopts
branch
from
7fb2e9f to
0970ffa
Compare
|
should we bump version? |
|
In WP we are using elixir |
That won't be needed. |
We can do that. |
how does this work? will |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we always called
:inet.setopts/2when a timeout was detected to set{linger, {true, 0}}to immediately tear down the socket before closing the connection. In doing so and in the case of tls the sslsocket structure gets passed to:prim_inet.setopts/2where the first argument is expected to be a port identifier.