Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIL uses a width,height tuple for resize() and thumbnail(). #121

Merged
merged 1 commit into from
May 12, 2024

Conversation

FreeBear-nc
Copy link
Contributor

Using a 300x480 img object, and surprised to find the image was being resized to 480x300 with fitscreen=true.
Looking at the image_to_rgb565 routine in the openHASP custom component, height & width had been transposed.

@dgomes
Copy link
Collaborator

dgomes commented May 2, 2024

Interesting catch... how this went by for so long

@FreeBear-nc
Copy link
Contributor Author

If you only ever used a 1:1 aspect ratio, it would never be noticed.

@fvanroie
Copy link
Collaborator

fvanroie commented May 3, 2024

fitscreen is relatively new and not extensively documented/used I guess...

@fvanroie fvanroie merged commit 10833d3 into HASwitchPlate:main May 12, 2024
2 checks passed
@fvanroie
Copy link
Collaborator

I made a 0.7.3 pre-release and also set 0.7.2 as latest version.

@FreeBear-nc Please test 0.7.3 and if all is well, that will be the latest release, sometime next week.

@FreeBear-nc
Copy link
Contributor Author

Appears to be functioning as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants