chore: Remove wallet connect v1 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raspLarry
approved these changes
Aug 3, 2023
EddieYS95
reviewed
Aug 14, 2023
Comment on lines
97
to
100
| #if UNITY_ANDROID | ||
| await this.Connect(); | ||
| #endif | ||
| await this.Connect(); |
There was a problem hiding this comment.
#if UNITY_ANDROID 일때를 묵은 이유가 있을까용? 이렇게 빠지면 Connect가 두번 호출될것 같은데 어떤 이슈가 있었나용?
Comment on lines
40
to
42
| #if UNITY_IOS | ||
| // await this._walletConnectClient.Connect(); | ||
| #endif |
|
제가 만든 PR이라 approve가 안되네요. |
EddieYS95
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.