Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deepkit): try to add support to deepkit #39

Merged
merged 12 commits into from
Aug 5, 2022
Merged

feat(deepkit): try to add support to deepkit #39

merged 12 commits into from
Aug 5, 2022

Conversation

H4ad
Copy link
Owner

@H4ad H4ad commented Aug 2, 2022

Description of change

Add support to integrate with @deepkit.

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Added documentation inside www/docs/main folder.
  • Included new files inside index.doc.ts.
  • The new commits follow conventions outlined in the conventional commit spec

@H4ad H4ad added the enhancement New feature or request label Aug 2, 2022
@H4ad H4ad self-assigned this Aug 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #39 (d401a8d) into main (b83874c) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              main      #39      +/-   ##
===========================================
- Coverage   100.00%   99.80%   -0.20%     
===========================================
  Files           39       45       +6     
  Lines          970     1039      +69     
  Branches       231      235       +4     
===========================================
+ Hits           970     1037      +67     
- Misses           0        2       +2     
Impacted Files Coverage Δ
src/frameworks/deepkit/http-deepkit.framework.ts 100.00% <100.00%> (ø)
src/frameworks/lazy/lazy.framework.ts 95.23% <0.00%> (-4.77%) ⬇️
src/serverless-adapter.ts 98.03% <0.00%> (-1.97%) ⬇️
src/core/headers.ts 100.00% <0.00%> (ø)
src/core/is-binary.ts 100.00% <0.00%> (ø)
src/network/request.ts 100.00% <0.00%> (ø)
src/core/base-handler.ts 100.00% <0.00%> (ø)
src/adapters/aws/alb.adapter.ts 100.00% <0.00%> (ø)
src/adapters/aws/sns.adapter.ts 100.00% <0.00%> (ø)
src/adapters/aws/sqs.adapter.ts 100.00% <0.00%> (ø)
... and 22 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@H4ad H4ad force-pushed the feature/deepkit branch 2 times, most recently from fabdc10 to a2d6f6b Compare August 3, 2022 03:20
@H4ad H4ad marked this pull request as ready for review August 4, 2022 03:03
@H4ad
Copy link
Owner Author

H4ad commented Aug 4, 2022

The issue with coverage is related with bcoe/c8#325 and nodejs/node#41387.
My only solution in this case is to migrate to mocha, like GoogleChrome/lighthouse#14047, very sad.

@H4ad H4ad merged commit 9d20837 into main Aug 5, 2022
@H4ad H4ad deleted the feature/deepkit branch August 5, 2022 02:51
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants