Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: improve splash screen manager logic by using ini helper intensively #384

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

Guts
Copy link
Owner

@Guts Guts commented Dec 29, 2023

No description provided.

@Guts Guts self-assigned this Dec 29, 2023
@github-actions github-actions bot added the jobs Scenarios and jobs label Dec 29, 2023
@Guts Guts force-pushed the feature/improve-splash-screen-manager-logic branch from eb7b4fc to c8d8aea Compare December 29, 2023 17:25
Copy link

sonarcloud bot commented Dec 29, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ee6def5) 70.97% compared to head (c8d8aea) 71.29%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
+ Coverage   70.97%   71.29%   +0.32%     
==========================================
  Files          43       43              
  Lines        2453     2449       -4     
  Branches      522      521       -1     
==========================================
+ Hits         1741     1746       +5     
+ Misses        540      526      -14     
- Partials      172      177       +5     
Files Coverage Δ
...s_deployment_toolbelt/profiles/qgis_ini_handler.py 68.18% <100.00%> (+3.68%) ⬆️
qgis_deployment_toolbelt/jobs/job_splash_screen.py 64.81% <66.66%> (-3.05%) ⬇️

... and 2 files with indirect coverage changes

@Guts Guts merged commit ded95c3 into main Dec 29, 2023
25 checks passed
@Guts Guts deleted the feature/improve-splash-screen-manager-logic branch December 29, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jobs Scenarios and jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants