Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add file size to downloader log #369

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

Guts
Copy link
Owner

@Guts Guts commented Dec 28, 2023

No description provided.

@github-actions github-actions bot added the quality Tests, project resiliency, etc. label Dec 28, 2023
@Guts Guts self-assigned this Dec 28, 2023
@Guts Guts added enhancement New feature or request and removed quality Tests, project resiliency, etc. labels Dec 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05399d9) 67.05% compared to head (365c0f1) 66.94%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
- Coverage   67.05%   66.94%   -0.12%     
==========================================
  Files          43       43              
  Lines        2383     2384       +1     
  Branches      512      512              
==========================================
- Hits         1598     1596       -2     
- Misses        635      637       +2     
- Partials      150      151       +1     
Files Coverage Δ
qgis_deployment_toolbelt/utils/file_downloader.py 86.48% <100.00%> (+0.37%) ⬆️

... and 1 file with indirect coverage changes

@Guts Guts force-pushed the feature/add-file-size-to-downloader-log branch from 2ceab47 to 365c0f1 Compare December 28, 2023 11:58
@Guts Guts added quality Tests, project resiliency, etc. enhancement New feature or request and removed enhancement New feature or request quality Tests, project resiliency, etc. labels Dec 28, 2023
Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts merged commit 1acb509 into main Dec 28, 2023
25 checks passed
@Guts Guts deleted the feature/add-file-size-to-downloader-log branch December 28, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants