Minor Python review to build a query string in Server tests #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests failed for Qt 5One or more tests failed using the build from commit 531eb6a WMS_GetMap_Highlight_LineWMS_GetMap_Highlight_LineTest failed at test_wms_getmap_highlight_line at tests/src/python/test_qgsserver_wms_getmap.py:1366 Rendered image did not match tests/testdata/control_images/qgis_server/WMS_GetMap_Highlight_Line/WMS_GetMap_Highlight_Line.png (found 7262 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
Gustry
force-pushed
the
build_query_string
branch
4 times, most recently
from
fd18cdd to
531eb6a
Compare
Gustry
force-pushed
the
build_query_string
branch
from
531eb6a to
0eea2b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Replace this with some text explaining the rationale and details about this pull request]