send alpn extension in client hello for baidu tts #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchen9922 are you familiar with installing a custom extension in anki? Curious if this patch fixes the bug for you. |
Baidu web server seems to behave nondeterministically when the extension is not supplied, sometimes returning 200 OK but with Content-Length 0. When the extension is sent, the audio/mpeg content is returned as expected. Automatically sending the alpn extension was added in python 3.10 (python/cpython@f97406b), but Anki is still using 3.9. Close Gustaf-C#61.
kieranlblack
force-pushed
the
baidu-tts-fix
branch
from
9cad254 to
b6ee8ab
Compare
|
@kieranlblack No sorry, I've never installed a custom extension in anki before. I tried to find a tutorial on YouTube, but nothing popped up :( |
|
Thanks Kieran, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baidu web server seems to behave nondeterministically when the extension is not supplied, sometimes returning 200 OK but with Content-Length 0. When the extension is sent, the audio/mpeg content is returned as expected. Automatically sending the alpn extension was added in python 3.10 (python/cpython@f97406b), but Anki is still using 3.9.
Close #61.